Add OS Thunderbolts #4062
Merged
Add OS Thunderbolts #4062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
added
Errata
Codecov ReportBase: 23.00% // Head: 23.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4062 +/- ##
============================================
+ Coverage 23.00% 23.02% +0.02%
- Complexity 4813 4825 +12
============================================
Files 2264 2276 +12
Lines 249505 249591 +86
Branches 46325 46327 +2
============================================
+ Hits 57398 57473 +75
- Misses 190648 190659 +11
Partials 1459 1459
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…olt_OS # Conflicts: # megamek/src/megamek/common/weapons/missiles/ISThunderbolt15IOS.java # megamek/src/megamek/common/weapons/missiles/ISThunderbolt20IOS.java # megamek/src/megamek/common/weapons/missiles/ISThunderbolt5IOS.java # megamek/src/megamek/common/weapons/missiles/ISThunderbolt5OS.java
|
I looked at IO and the advancement tables some more and I improved the TechAdvancement some more. So now ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2177
Adds OS/IOS Thunderbolt versions for construction and use, tested in MML and MM.
To reduce code duplication this expands the hierarchy of Thunderbolts. ThunderboltWeapon -> Thunderbolt##Weapon -> Thunderbolt##, Thunderbolt##OS, Thunderbolt##IOS where ## is the rack size.
@HammerGS The TechAdvancement for the normal Tbs is probably ok, but would you be able to help me with the TA for the OS and IOS. I copied in some TA from another OS weapon but that's probably off in some way.